netdev - Re: [PATCH net v4] net: devmem: fix kernel panic when netlink socket close after module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513073016.2ab40a90@kernel.org>
Date: Tue, 13 May 2025 07:30:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 horms@...nel.org, almasrymina@...gle.com, sdf@...ichev.me,
 netdev@...r.kernel.org, asml.silence@...il.com, dw@...idwei.uk,
 skhawaja@...gle.com, kaiyuanz@...gle.com, jdamato@...tly.com
Subject: Re: [PATCH net v4] net: devmem: fix kernel panic when netlink
 socket close after module unload

On Tue, 13 May 2025 12:24:52 +0900 Taehee Yoo wrote:
> > On Mon, 12 May 2025 08:40:59 +0000 Taehee Yoo wrote:  
> > > @@ -943,8 +943,6 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)
> > >                       goto err_unbind;
> > >       }
> > >
> > > -     list_add(&binding->list, &priv->bindings);  
> >
> > Please leave this list_add() where it was.  
> 
> list_add() is moved to net_devmem_bind_dmabuf() by this patch.
> So, you mean that let's make net_devmem_{bind | unbind}_dmabuf()
> don't handle list themself like the v3 patch, right?

Not exactly like in v3. In v3 list_del() was moved. I think these moves
are due to cleanup which I requested earlier? There is no functional
need for these? I'm giving up on that cleanup request for now. 
Let's leave the list modifications where they are.