netdev - Re: [PATCH v2] net: bcmgenet: tidy up stats, expose more stats in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA+QEuT0tPd0Qxjy0LP2zXhRhAe_bRv5omFPaFdbHVzoBAO-Yw@mail.gmail.com>
Date: Tue, 13 May 2025 20:26:47 +0100
From: Zak Kemble <zakkemble@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Doug Berger <opendmb@...il.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: bcmgenet: tidy up stats, expose more stats in ethtool

Hey Simon, sorry I'm still figuring out mailing lists lol. This v2 was
submitted after the kernel test bot had replied about a warning, but
before anyone else had a chance to reply. Latest version is here
https://lore.kernel.org/all/20250513144107.1989-1-zakkemble@gmail.com/

On Tue, 13 May 2025 at 10:45, Simon Horman <horms@...nel.org> wrote:
>
> On Mon, May 12, 2025 at 11:15:20AM +0100, Zak Kemble wrote:
> > This patch exposes more statistics counters in ethtool and tidies up the
> > counters so that they are all per-queue. The netdev counters are now only
> > updated synchronously in bcmgenet_get_stats instead of a mix of sync/async
> > throughout the driver. Hardware discarded packets are now counted in their
> > own missed stat instead of being lumped in with general errors.
> >
> > Changes in v2:
> > - Remove unused variable
> > - Link to v1: https://lore.kernel.org/all/20250511214037.2805-1-zakkemble%40gmail.com
>
> Hi Zak,
>
> nit: These days it is preferred to put Changes information, such as the
>      above, below the scissors ("---"). That way it is available to
>      reviewers (thanks!) and will appear in mailing list archives and so
>      on. But is omitted in git history as the commit message is
>      truncated at the scissors.
>
> >
> > Signed-off-by: Zak Kemble <zakkemble@...il.com>
>
> This does not appear to address the review of Andrew and Florian of v1.
> I think the way forwards is to engage with them on the preferred way
> forwards. Or somehow note that you have done so.
>
> --
> pw-bot: changes-requested