netdev - Re: [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLi=21Z=qd4OgxfWsQVR06suwKdfGncgEu88BSD44TGUo6Q@mail.gmail.com>
Date: Mon, 12 May 2025 22:41:17 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com, sdf@...ichev.me, 
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset_task()

On Mon, May 12, 2025 at 6:14 PM Stanislav Fomichev <stfomichev@...il.com> wrote:
>
> On 05/12, Jakub Kicinski wrote:
> > I'd go with Michael's patch for net and revisit in net-next if you're
> > filling bold.
>
> Good point. But in this case, we need to cover more? bnxt_open from
> bnxt_resume and the callers of bnxt_reset?

You are right.  We haven't tested suspend/resume, PCI AER, and TX
timeout yet and these will have the same problem.  Let me expand on
the original fix and get these code paths tested tomorrow.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)