netdev - Re: [PATCH net-next 05/10] selftest/net/ovpn: fix crash in case of getaddrinfo() failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b95deb4-d1f2-47c3-96fd-65d2a8edd775@redhat.com>
Date: Tue, 13 May 2025 09:48:24 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Antonio Quartulli <antonio@...nvpn.net>, netdev@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH net-next 05/10] selftest/net/ovpn: fix crash in case of
 getaddrinfo() failure

On 5/9/25 4:26 PM, Antonio Quartulli wrote:
> getaddrinfo() may fail with error code different from EAI_FAIL
> or EAI_NONAME, however in this case we still try to free the
> results object, thus leading to a crash.
> 
> Fix this by bailing out on any possible error.
> 
> Fixes: 959bc330a439 ("testing/selftests: add test tool and scripts for ovpn module")
> Signed-off-by: Antonio Quartulli <antonio@...nvpn.net>
> ---
>  tools/testing/selftests/net/ovpn/ovpn-cli.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/ovpn/ovpn-cli.c b/tools/testing/selftests/net/ovpn/ovpn-cli.c
> index 69e41fc07fbc..c6372a1b4728 100644
> --- a/tools/testing/selftests/net/ovpn/ovpn-cli.c
> +++ b/tools/testing/selftests/net/ovpn/ovpn-cli.c
> @@ -1753,8 +1753,11 @@ static int ovpn_parse_remote(struct ovpn_ctx *ovpn, const char *host,
>  
>  	if (host) {
>  		ret = getaddrinfo(host, service, &hints, &result);
> -		if (ret == EAI_NONAME || ret == EAI_FAIL)
> +		if (ret) {
> +			fprintf(stderr, "getaddrinfo on remote error: %s\n",
> +				gai_strerror(ret));
>  			return -1;

Side note: you could instead use the libcall error(), even if at this
point it would be a quite largish self-test refactor.

/P