netdev - Re: [net-next v2 PATCH 2/2] octeontx2-pf: macsec: Get MACSEC capability flag from AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250514125640.GN3339421@horms.kernel.org>
Date: Wed, 14 May 2025 13:56:40 +0100
From: Simon Horman <horms@...nel.org>
To: Subbaraya Sundeep <sbhatta@...vell.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, gakula@...vell.com,
	hkelam@...vell.com, sgoutham@...vell.com, lcherian@...vell.com,
	bbhushan2@...vell.com, jerinj@...vell.com, netdev@...r.kernel.org
Subject: Re: [net-next v2 PATCH 2/2] octeontx2-pf: macsec: Get MACSEC
 capability flag from AF

On Tue, May 13, 2025 at 08:32:07AM +0000, Subbaraya Sundeep wrote:

Hi Subbaraya,

> Hi Simon,
> 
> On 2025-05-12 at 16:37:32, Simon Horman (horms@...nel.org) wrote:
> > On Sun, May 11, 2025 at 06:52:47PM +0530, Subbaraya Sundeep wrote:

...

> > Hi Subbaraya,
> > 
> > If I read things correctly otx2_setup_dev_hw_settings() is called
> > for both representors and non-representors, while otx2_probe is
> > only called for non-representors.
> > 
> > If so, my question is if this patch changes behaviour for representors.
> > And, again if so, if that is intentional.
> I assume you mean VF driver for representors and PF driver for
> non-representor. Yes this is intentional. We currently do not support
> macscec offload on VFs hence I changed only PF driver. In case we want
> to support macsec offload on VFs too then otx2vf_probe also need to be
> changed like:
> otx2_set_hw_capabilities(vf);
> err = cn10k_mcs_init(vf);

Thanks for the clarification.
In that case this patch looks good ti me.

Reviewed-by: Simon Horman <horms@...nel.org>