netdev - Re: [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b333c97-4bdd-4238-bfab-b0f137e5b869@linux.intel.com>
Date: Wed, 14 May 2025 15:44:49 +0200
From: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe
 and ice drivers

Hi Jakub,

The link-down events counter increments upon actual physical link-down 
events, doesn't increment when user performs a simple down/up of the 
interface. However there is indeed link down event from firmware - as 
part of interface reinitialization eg. when attaching XDP program, 
reconfiguring channels and setting interface priv-flags. In those cases, 
the interface is stopped and then brought back up.

I will add more these details in the cover letter.

Thank you!
Martyna

On 5/13/2025 2:21 AM, Jakub Kicinski wrote:
> On Mon, 12 May 2025 11:05:14 +0200 Martyna Szapar-Mudlaw wrote:
>> This series introduces link_down_events counters to the ixgbe and ice drivers.
>> The counters are incremented each time the link transitions from up to down,
>> allowing better diagnosis of link stability issues such as port flapping or
>> unexpected link drops.
> 
> To confirm, will the counter increment:
>   - when link is held up by BMC / NC-SI or some other agent
>     and user does down/up on the host?
>   - when user reconfigures channels, attaches XDP etc?
> 
> Would be good to document that in the cover letter.
>