netdev - Re: [PATCH net-next] ovpn: properly deconfigure UDP-tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47be0947-809d-4ca1-bfa0-018853ab4df2@openvpn.net>
Date: Wed, 14 May 2025 16:18:11 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Sabrina Dubroca <sd@...asysnail.net>,
 David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] ovpn: properly deconfigure UDP-tunnel

On 14/05/2025 16:02, Antonio Quartulli wrote:
> 
> 
> On 14/05/2025 15:50, Jakub Kicinski wrote:
>> On Wed, 14 May 2025 11:58:42 +0200 Antonio Quartulli wrote:
>>> +#if IS_ENABLED(CONFIG_IPV6)
>>> +    if (READ_ONCE(sk->sk_family) == PF_INET6)
>>> +        static_branch_dec(&udpv6_encap_needed_key);
>>
>> udpv6_encap_needed_key is only exported for ipv6.ko
>> I think you need to correct the export, because with IPV6=y
>> and UDP_TUNNEL=m we get:
>>
>> ERROR: modpost: "udpv6_encap_needed_key" [net/ipv4/udp_tunnel.ko] 
>> undefined!
> 
> Or define and export udpv6_encap_enable() which calls only the 

EDIT: I meant udpv6_encap_disable() here ^^

> static_branch_dec()?
> Basically the same as the current udpv6_encap_enable().
> 
> This way we don't need to touch the export for udpv6_encap_needed_key.
> 
> Regards,
> 

-- 
Antonio Quartulli
OpenVPN Inc.