netdev - Re: [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8314acf3-642b-4e39-8cbc-e6e15d7a3741@linux.intel.com>
Date: Wed, 14 May 2025 16:59:08 +0200
From: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe
 and ice drivers



On 5/14/2025 4:42 PM, Jakub Kicinski wrote:
> On Wed, 14 May 2025 15:44:49 +0200 Szapar-Mudlaw, Martyna wrote:
>> The link-down events counter increments upon actual physical link-down
>> events, doesn't increment when user performs a simple down/up of the
>> interface.
>>
>> However there is indeed link down event from firmware - as
>> part of interface reinitialization eg. when attaching XDP program,
>> reconfiguring channels and setting interface priv-flags.
> 
> Maybe I'm misunderstanding, but are you saying that the link-down
> counter doesn't increment on ifdown+ifup but it does increment
> when attaching an XDP prog?
> 
> The definition of link_down_events is pretty simple - (plus minus
> the quantum world of signals) the link_down_events is physical link
> downs which the switch / remote end will also see. Unlike software
> carrier off which may just configure the MAC or the NIC pipeline to
> drop but the PHY stays connected / trained / synchronized.
> 

Agree. I said that it increments when physical link gets down and not 
eg. when user performs ip link set dev eth down.
So this implementation of link_down_events counter is consistent with 
the definition you provided.

Regards,
Martyna