netdev - Re: [PATCH net-next 2/2] net: lan743x: implement ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7af0e1e-7ba2-48d0-9a0f-4903dbe97421@linux.dev>
Date: Wed, 14 May 2025 22:27:42 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc: Bryan Whitehead <bryan.whitehead@...rochip.com>,
 Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>,
 Vishvambar Panth S <vishvambarpanth.s@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next 2/2] net: lan743x: implement ndo_hwtstamp_get()

On 14/05/2025 16:19, Vladimir Oltean wrote:
> Permit programs such as "hwtstamp_ctl -i eth0" to retrieve the current
> timestamping configuration of the NIC, rather than returning "Device
> driver does not have support for non-destructive SIOCGHWTSTAMP."
> 
> The driver configures all channels with the same timestamping settings.
> On TX, retrieve the settings of the first channel, those should be
> representative for the entire NIC. On RX, save the filter settings in a
> new adapter field.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>   drivers/net/ethernet/microchip/lan743x_main.c |  2 ++
>   drivers/net/ethernet/microchip/lan743x_main.h |  1 +
>   drivers/net/ethernet/microchip/lan743x_ptp.c  | 18 ++++++++++++++++++
>   drivers/net/ethernet/microchip/lan743x_ptp.h  |  3 ++-
>   4 files changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
> index b01695bf4f55..880681085df2 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.c
> +++ b/drivers/net/ethernet/microchip/lan743x_main.c
> @@ -1729,6 +1729,7 @@ int lan743x_rx_set_tstamp_mode(struct lan743x_adapter *adapter,
>   	default:
>   			return -ERANGE;
>   	}
> +	adapter->rx_tstamp_filter = rx_filter;
>   	return 0;
>   }
>   
> @@ -3445,6 +3446,7 @@ static const struct net_device_ops lan743x_netdev_ops = {
>   	.ndo_change_mtu		= lan743x_netdev_change_mtu,
>   	.ndo_get_stats64	= lan743x_netdev_get_stats64,
>   	.ndo_set_mac_address	= lan743x_netdev_set_mac_address,
> +	.ndo_hwtstamp_get	= lan743x_ptp_hwtstamp_get,
>   	.ndo_hwtstamp_set	= lan743x_ptp_hwtstamp_set,
>   };
>   
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.h b/drivers/net/ethernet/microchip/lan743x_main.h
> index db5fc73e41cc..02a28b709163 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.h
> +++ b/drivers/net/ethernet/microchip/lan743x_main.h
> @@ -1087,6 +1087,7 @@ struct lan743x_adapter {
>   	phy_interface_t		phy_interface;
>   	struct phylink		*phylink;
>   	struct phylink_config	phylink_config;
> +	int			rx_tstamp_filter;
>   };
>   
>   #define LAN743X_COMPONENT_FLAG_RX(channel)  BIT(20 + (channel))
> diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
> index 026d1660fd74..a3b48388b3fd 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
> @@ -1736,6 +1736,24 @@ void lan743x_ptp_tx_timestamp_skb(struct lan743x_adapter *adapter,
>   	lan743x_ptp_tx_ts_complete(adapter);
>   }
>   
> +int lan743x_ptp_hwtstamp_get(struct net_device *netdev,
> +			     struct kernel_hwtstamp_config *config)
> +{
> +	struct lan743x_adapter *adapter = netdev_priv(netdev);
> +	struct lan743x_tx *tx = &adapter->tx[0];
> +
> +	if (tx->ts_flags & TX_TS_FLAG_ONE_STEP_SYNC)
> +		config->tx_type = HWTSTAMP_TX_ONESTEP_SYNC;
> +	else if (tx->ts_flags & TX_TS_FLAG_TIMESTAMPING_ENABLED)
> +		config->tx_type = HWTSTAMP_TX_ON;
> +	else
> +		config->tx_type = HWTSTAMP_TX_OFF;
> +
> +	config->rx_filter = adapter->rx_tstamp_filter;
> +
> +	return 0;
> +}
> +
>   int lan743x_ptp_hwtstamp_set(struct net_device *netdev,
>   			     struct kernel_hwtstamp_config *config,
>   			     struct netlink_ext_ack *extack)
> diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.h b/drivers/net/ethernet/microchip/lan743x_ptp.h
> index 9581a7992ff6..e8d073bfa2ca 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ptp.h
> +++ b/drivers/net/ethernet/microchip/lan743x_ptp.h
> @@ -51,7 +51,8 @@ int lan743x_ptp_open(struct lan743x_adapter *adapter);
>   void lan743x_ptp_close(struct lan743x_adapter *adapter);
>   void lan743x_ptp_update_latency(struct lan743x_adapter *adapter,
>   				u32 link_speed);
> -
> +int lan743x_ptp_hwtstamp_get(struct net_device *netdev,
> +			     struct kernel_hwtstamp_config *config);
>   int lan743x_ptp_hwtstamp_set(struct net_device *netdev,
>   			     struct kernel_hwtstamp_config *config,
>   			     struct netlink_ext_ack *extack);

Thanks for making this improvement. Looks like the pattern of not having
"get" callbacks got into this from phy drivers.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>