netdev - Re: [PATCH net-next v4 0/4] add broadcast_neighbor for no-stacking networking arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f11ade9c-753f-4128-a67a-edbe2f40c912@blackwall.org>
Date: Wed, 14 May 2025 12:34:33 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Tonghao Zhang <tonghao@...aicloud.com>, netdev@...r.kernel.org
Cc: Jay Vosburgh <jv@...sburgh.net>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>,
 Zengbing Tu <tuzengbing@...iglobal.com>
Subject: Re: [PATCH net-next v4 0/4] add broadcast_neighbor for no-stacking
 networking arch

On 5/14/25 12:25, Tonghao Zhang wrote:
> For no-stacking networking arch, and enable the bond mode 4(lacp) in
> datacenter, the switch require arp/nd packets as session synchronization.
> More details please see patch.
> 
> v4 change log:
> - fix dec option in bond_close
> 
> v3 change log:
> - inc/dec broadcast_neighbor option in bond_open/close and UP state.
> - remove explicit inline of bond_should_broadcast_neighbor
> - remove sysfs option
> - remove EXPORT_SYMBOL_GPL
> - reorder option bond_opt_value
> - use rcu_xxx in bond_should_notify_peers.
> 
> v2 change log:
> - add static branch for performance
> - add more info about no-stacking arch in commit message
> - add broadcast_neighbor info and format doc
> - invoke bond_should_broadcast_neighbor only in BOND_MODE_8023AD mode for performance
> - explain why we need sending peer notify when failure recovery
> - change the doc about num_unsol_na
> - refine function name to ad_cond_set_peer_notif
> - ad_cond_set_peer_notif invoked in ad_enable_collecting_distributing
> - refine bond_should_notify_peers for lacp mode.
> 
> Cc: Jay Vosburgh <jv@...sburgh.net>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Simon Horman <horms@...nel.org>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: Zengbing Tu <tuzengbing@...iglobal.com>
> 
> Tonghao Zhang (4):
>   net: bonding: add broadcast_neighbor option for 802.3ad
>   net: bonding: add broadcast_neighbor netlink option
>   net: bonding: send peer notify when failure recovery
>   net: bonding: add tracepoint for 802.3ad
> 
>  Documentation/networking/bonding.rst | 11 ++++-
>  drivers/net/bonding/bond_3ad.c       | 19 +++++++++
>  drivers/net/bonding/bond_main.c      | 63 +++++++++++++++++++++++++---
>  drivers/net/bonding/bond_netlink.c   | 16 +++++++
>  drivers/net/bonding/bond_options.c   | 35 ++++++++++++++++
>  include/net/bond_options.h           |  1 +
>  include/net/bonding.h                |  3 ++
>  include/trace/events/bonding.h       | 37 ++++++++++++++++
>  include/uapi/linux/if_link.h         |  1 +
>  9 files changed, 179 insertions(+), 7 deletions(-)
>  create mode 100644 include/trace/events/bonding.h
> 

Just fyi you should wait 24h before posting a new version as per netdev@ rules.
Also to give more people a chance to review the set. Please CC reviewers on
the full set, I had to chase the patches on the list separately.

Cheers,
 Nik