netdev - Re: [PATCH iwl-net v3 2/3] ice: create new Tx scheduler nodes for new queues only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515114632.GV3339421@horms.kernel.org>
Date: Thu, 15 May 2025 12:46:32 +0100
From: Simon Horman <horms@...nel.org>
To: Michal Kubiak <michal.kubiak@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, maciej.fijalkowski@...el.com,
	aleksander.lobakin@...el.com, przemyslaw.kitszel@...el.com,
	dawid.osuchowski@...ux.intel.com, jacob.e.keller@...el.com,
	jbrandeburg@...udflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-net v3 2/3] ice: create new Tx scheduler nodes for
 new queues only

On Tue, May 13, 2025 at 12:55:28PM +0200, Michal Kubiak wrote:
> The current implementation of the Tx scheduler tree attempts
> to create nodes for all Tx queues, ignoring the fact that some
> queues may already exist in the tree. For example, if the VSI
> already has 128 Tx queues and the user requests for 16 new queues,
> the Tx scheduler will compute the tree for 272 queues (128 existing
> queues + 144 new queues), instead of 144 queues (128 existing queues
> and 16 new queues).
> Fix that by modifying the node count calculation algorithm to skip
> the queues that already exist in the tree.
> 
> Fixes: 5513b920a4f7 ("ice: Update Tx scheduler tree for VSI multi-Tx queue support")
> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Michal Kubiak <michal.kubiak@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>