netdev - Re: [PATCH net-next v3] net: Add support for providing the PTP hardware source in tsinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6eed9e0-8f44-4ffb-b316-d65e0b5a192a@redhat.com>
Date: Thu, 15 May 2025 13:51:40 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kory Maincent <kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 Jakub Kicinski <kuba@...nel.org>, Donald Hunter <donald.hunter@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Simon Horman <horms@...nel.org>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Jason Xing <kernelxing@...cent.com>,
 Richard Cochran <richardcochran@...il.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 "Russell King (Oracle)" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v3] net: Add support for providing the PTP
 hardware source in tsinfo

On 5/13/25 1:40 PM, Kory Maincent wrote:
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index c650cd3dcb80bc93c5039dc8ba2c5c18793ff987..881e483f32e18f77c009f278bd2d2029c30af352 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -98,6 +98,23 @@ definitions:
>      name: tcp-data-split
>      type: enum
>      entries: [ unknown, disabled, enabled ]
> +  -
> +    name: hwtstamp-source
> +    enum-name: hwtstamp-source
> +    name-prefix: hwtstamp-source-
> +    type: enum
> +    entries:

This causes a kdoc warning in the generated hdr, lacking the short
description for the enum:

include/uapi/linux/ethtool_netlink_generated.h:42: warning: missing
initial short description on line:
 * enum hwtstamp_source

Please add a:
    doc: <>

section.

Thanks,

Paolo