netdev - Re: [net-next PATCH v10 7/7] rust: net::phy sync with match_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D9WPVECZK7GQ.2HAJ6JDN7M3LQ@kernel.org>
Date: Thu, 15 May 2025 14:01:22 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Christian Marangi" <ansuelsmth@...il.com>
Cc: "Andrew Lunn" <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, "Rob
 Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Heiner Kallweit"
 <hkallweit1@...il.com>, "Russell King" <linux@...linux.org.uk>, "Florian
 Fainelli" <florian.fainelli@...adcom.com>, "Broadcom internal kernel review
 list" <bcm-kernel-feedback-list@...adcom.com>, Marek Behún
 <kabel@...nel.org>, "Andrei Botila" <andrei.botila@....nxp.com>, "FUJITA
 Tomonori" <fujita.tomonori@...il.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <benno.lossin@...ton.me>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Danilo Krummrich" <dakr@...nel.org>,
 "Sabrina Dubroca" <sd@...asysnail.net>, "Michael Klein"
 <michael@...sekall.de>, "Daniel Golle" <daniel@...rotopia.org>,
 <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [net-next PATCH v10 7/7] rust: net::phy sync with
 match_phy_device C changes

On Thu May 15, 2025 at 1:51 PM CEST, Christian Marangi wrote:
> On Thu, May 15, 2025 at 01:49:35PM +0200, Benno Lossin wrote:
>> On Thu May 15, 2025 at 1:27 PM CEST, Christian Marangi wrote:
>> > Sync match_phy_device callback wrapper in net:phy rust with the C
>> > changes where match_phy_device also provide the passed PHY driver.
>> >
>> > As explained in the C commit, this is useful for match_phy_device to
>> > access the PHY ID defined in the PHY driver permitting more generalized
>> > functions.
>> >
>> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
>> > ---
>> >  rust/kernel/net/phy.rs | 26 +++++++++++++++++++++++---
>> >  1 file changed, 23 insertions(+), 3 deletions(-)
>> 
>> You probably should do this in the same commit as the C changes,
>> otherwise the in-between commits will error.
>> 
>
> You are right, I will fix this in v11 but I would really want to know if
> the Rust changes are correct. It's not my main language so it's all
> discovering new stuff :D

No worries :) I have lost some context on the PHY Rust bindings, so
Fujita will probably have to review it, but if I find the time, I'll
take a look.

---
Cheers,
Benno