netdev - Re: [PATCH net] vmxnet3: update MTU after device quiesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250515065444.60df21c0@kernel.org>
Date: Thu, 15 May 2025 06:54:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ronak Doshi <ronak.doshi@...adcom.com>
Cc: netdev@...r.kernel.org, Guolin Yang <guolin.yang@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Ronghua
 Zhang <ronghua@...are.com>, Bhavesh Davda <bhavesh@...are.com>, Shreyas
 Bhatewara <sbhatewara@...are.com>, linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net] vmxnet3: update MTU after device quiesce

On Tue, 13 May 2025 21:02:40 +0000 Ronak Doshi wrote:
> @@ -3619,6 +3617,7 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu)
>  	if (netif_running(netdev)) {
>  		vmxnet3_quiesce_dev(adapter);
>  		vmxnet3_reset_dev(adapter);
> +		WRITE_ONCE(netdev->mtu, new_mtu);
>  
>  		/* we need to re-create the rx queue based on the new mtu */
>  		vmxnet3_rq_destroy_all(adapter);

Maybe a nit pick but wouldn't it make the most sense to place the write
after all teardown related code? So after vmxnet3_rq_destroy_all() ?