netdev - Re: [PATCH] r8152: Add wake up function for RTL8153

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1308504-cb6c-4085-a1b6-fb30e145ff25@lunn.ch>
Date: Thu, 15 May 2025 18:08:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, ste3ls@...il.com,
	hayeswang@...ltek.com, dianders@...omium.org, gmazyland@...il.com,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8152: Add wake up function for RTL8153

On Thu, May 15, 2025 at 11:11:30PM +0800, Wentao Liang wrote:
> In rtl8153_runtime_enable(), the runtime enable/disable logic for RTL8153
> devices was incomplete, missing r8153_queue_wake() to enable or disable
> the automatic wake-up function. A proper implementation can be found in
> rtl8156_runtime_enable().
> 
> Add r8153_queue_wake(tp, true) if enable flag is set true, and add
> r8153_queue_wake(tp, false) otherwise.
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

Is this for stable? Should it have a Fixes: tag?

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

	Andrew