netdev - Re: [PATCH net-next] net: sched: uapi: add more sanely named duplicate defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515182413.GX3339421@horms.kernel.org>
Date: Thu, 15 May 2025 19:24:13 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: uapi: add more sanely named
 duplicate defines

On Tue, May 13, 2025 at 03:17:52PM -0700, Jakub Kicinski wrote:
> The TCA_FLOWER_KEY_CFM enum has a UNSPEC and MAX with _OPT
> in the name, but the real attributes don't. Add a MAX that
> more reasonably matches the attrs.
> 
> The PAD in TCA_TAPRIO is the only attr which doesn't have
> _ATTR in it, perhaps signifying that it's not a real attr?
> If so interesting idea in abstract but it makes codegen painful.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>