netdev - Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03216908-6675-4487-a7e1-4a42d169c401@intel.com>
Date: Thu, 15 May 2025 07:39:18 +0300
From: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>
To: Vlad URSU <vlad@...u.me>, Jacek Kowalski <jacek@...ekk.info>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp
 when valid checksum mask is not set



On 5/12/2025 8:25 PM, Vlad URSU wrote:
> On 22.04.2025 10:43, Jacek Kowalski wrote:
>> Some Dell Tiger Lake systems have incorrect NVM checksum. These also
>> have a bitmask that indicates correct checksum set to "invalid".
>>
>> Because it is impossible to determine whether the NVM write would finish
>> correctly or hang (see https://bugzilla.kernel.org/show_bug.cgi? 
>> id=213667)
>> it makes sense to skip the validation completely under these conditions.
>>
>> Signed-off-by: Jacek Kowalski <Jacek@...ekk.info>
>> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM 
>> checksum")
>> Cc: stable@...r.kernel.org
>> ---
>>   drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/ 
>> net/ethernet/intel/e1000e/ich8lan.c
>> index 364378133526..df4e7d781cb1 100644
>> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
>> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
>> @@ -4274,6 +4274,8 @@ static s32 
>> e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw)
>>               ret_val = e1000e_update_nvm_checksum(hw);
>>               if (ret_val)
>>                   return ret_val;
>> +        } else if (hw->mac.type == e1000_pch_tgp) {
>> +            return 0;
>>           }
>>       }
>>
> 
> This patch doesn't work for me on an Optiplex 5090 Micro (i5-10500T). I 
> did some debugging and the platform is recognized as Tiger Lake, by the 
> driver, but the checksum valid bit is set even though the checksum is 
> not valid.
> 
> The network controller works fine if I patch out the validation in 
> netdev.c. The checksum word at address 0x7e read using ethtool is 0xffff.
> 
> I'm also a bit confused about why the driver reports the mac type as 
> e1000_pch_tgp even though i5-10500T should be Comet Lake?

The device is being recognized by the device ID. Probably the device you 
have on your system is TGP.

Since the checksum word is 0xFFFF which is peculiar, can you dump the 
whole NVM and share with us?