netdev - Re: [PATCH v1 2/2] ethernet: eswin: Add eic7700 ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516073217.115fc170@kernel.org>
Date: Fri, 16 May 2025 07:32:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: weishangjuan@...incomputing.com
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, richardcochran@...il.com, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
 p.zabel@...gutronix.de, yong.liang.choong@...ux.intel.com,
 rmk+kernel@...linux.org.uk, jszhang@...nel.org, inochiama@...il.com,
 jan.petrous@....nxp.com, dfustini@...storrent.com, 0x1207@...il.com,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, ningyu@...incomputing.com,
 linmin@...incomputing.com, lizhi2@...incomputing.com
Subject: Re: [PATCH v1 2/2] ethernet: eswin: Add eic7700 ethernet driver

On Fri, 16 May 2025 09:11:28 +0800 weishangjuan@...incomputing.com
wrote:
> +	dwc_priv->clk_tx = devm_clk_get(&pdev->dev, "tx");
> +	if (IS_ERR(plat_dat->pclk)) {

you're checking the wrong pointer here

> +		dev_err(&pdev->dev, "tx clock not found.\n");
> +		return PTR_ERR(dwc_priv->clk_tx);
-- 
pw-bot: cr