netdev - Re: [PATCH net] selftests: net: validate team flags propagation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCd7Fj9kr_pbhQaO@mini-arch>
Date: Fri, 16 May 2025 10:51:18 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	jiri@...nulli.us, shuah@...nel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: validate team flags propagation

On 05/16, Jakub Kicinski wrote:
> On Thu, 15 May 2025 16:13:32 -0700 Stanislav Fomichev wrote:
> > Cover three recent cases:
> > 1. missing ops locking for the lowers during netdev_sync_lower_features
> > 2. missing locking for dev_set_promiscuity (plus netdev_ops_assert_locked
> >    with a comment on why/when it's needed)
> > 3. rcu lock during team_change_rx_flags
> > 
> > Verified that each one triggers when the respective fix is reverted.
> > Not sure about the placement, but since it all relies on teaming,
> > added to the teaming directory.
> > 
> > One ugly bit is that I add NETIF_F_LRO to netdevsim; there is no way
> > to trigger netdev_sync_lower_features without it.
> 
> Seems to consistently fail in NIPA :(
> -- 
> pw-bot: cr

Cleanup is a bit messy. Will add set +e and retest locally with vng,
thanks!