netdev - Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c8999a7-d586-4bc6-9912-b088d9c3049f@molgen.mpg.de>
Date: Fri, 16 May 2025 22:57:32 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 Konrad Knitter <konrad.knitter@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs

Dear Dawid,


Thank you for your patch.

Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
> E835 is an enhanced version of the E830.
> It continues to use the same set of commands, registers and interfaces
> as other devices in the 800 Series.
> 
> Following device IDs are added:
> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP

Should you resend, it’d be great, if you added the datasheet name, where 
these id’s are present.

> Reviewed-by: Konrad Knitter <konrad.knitter@...el.com>
> Signed-off-by: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_common.c |  9 +++++++++
>   drivers/net/ethernet/intel/ice/ice_devids.h | 18 ++++++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_main.c   |  9 +++++++++
>   3 files changed, 36 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index 6e38d46c2c51..010ad09b3200 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -171,6 +171,15 @@ static int ice_set_mac_type(struct ice_hw *hw)
>   	case ICE_DEV_ID_E830_XXV_QSFP:
>   	case ICE_DEV_ID_E830C_SFP:
>   	case ICE_DEV_ID_E830_XXV_SFP:
> +	case ICE_DEV_ID_E835CC_BACKPLANE:
> +	case ICE_DEV_ID_E835CC_QSFP56:
> +	case ICE_DEV_ID_E835CC_SFP:
> +	case ICE_DEV_ID_E835C_BACKPLANE:
> +	case ICE_DEV_ID_E835C_QSFP:
> +	case ICE_DEV_ID_E835C_SFP:
> +	case ICE_DEV_ID_E835_L_BACKPLANE:
> +	case ICE_DEV_ID_E835_L_QSFP:
> +	case ICE_DEV_ID_E835_L_SFP:
>   		hw->mac_type = ICE_MAC_E830;
>   		break;
>   	default:
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index 34fd604132f5..7761c3501174 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -36,6 +36,24 @@
>   #define ICE_DEV_ID_E830_XXV_QSFP	0x12DD
>   /* Intel(R) Ethernet Controller E830-XXV for SFP */
>   #define ICE_DEV_ID_E830_XXV_SFP		0x12DE
> +/* Intel(R) Ethernet Controller E835-CC for backplane */
> +#define ICE_DEV_ID_E835CC_BACKPLANE	0x1248
> +/* Intel(R) Ethernet Controller E835-CC for QSFP */
> +#define ICE_DEV_ID_E835CC_QSFP56	0x1249
> +/* Intel(R) Ethernet Controller E835-CC for SFP */
> +#define ICE_DEV_ID_E835CC_SFP		0x124A
> +/* Intel(R) Ethernet Controller E835-C for backplane */
> +#define ICE_DEV_ID_E835C_BACKPLANE	0x1261
> +/* Intel(R) Ethernet Controller E835-C for QSFP */
> +#define ICE_DEV_ID_E835C_QSFP		0x1262
> +/* Intel(R) Ethernet Controller E835-C for SFP */
> +#define ICE_DEV_ID_E835C_SFP		0x1263
> +/* Intel(R) Ethernet Controller E835-L for backplane */
> +#define ICE_DEV_ID_E835_L_BACKPLANE	0x1265
> +/* Intel(R) Ethernet Controller E835-L for QSFP */
> +#define ICE_DEV_ID_E835_L_QSFP		0x1266
> +/* Intel(R) Ethernet Controller E835-L for SFP */
> +#define ICE_DEV_ID_E835_L_SFP		0x1267
>   /* Intel(R) Ethernet Controller E810-C for backplane */
>   #define ICE_DEV_ID_E810C_BACKPLANE	0x1591
>   /* Intel(R) Ethernet Controller E810-C for QSFP */
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index c4264984cfcb..5c941f4426d1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5906,6 +5906,15 @@ static const struct pci_device_id ice_pci_tbl[] = {
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_QSFP), },
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830C_SFP), },
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_SFP), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_BACKPLANE), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_QSFP56), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_SFP), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_BACKPLANE), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_QSFP), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_SFP), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_BACKPLANE), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_QSFP), },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_SFP), },
>   	/* required last entry */
>   	{}
>   };


Kind regards,

Paul