netdev - RE: [EXTERNAL] Re: [PATCH net-next] net: mana: Add support for Multi Vports on Bare metal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MN0PR21MB3437ED3FC34206052262C43ECA93A@MN0PR21MB3437.namprd21.prod.outlook.com>
Date: Fri, 16 May 2025 21:45:51 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: Dexuan Cui <decui@...rosoft.com>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>, KY Srinivasan <kys@...rosoft.com>, Paul
 Rosswurm <paulros@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "leon@...nel.org"
	<leon@...nel.org>, Long Li <longli@...rosoft.com>,
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"daniel@...earbox.net" <daniel@...earbox.net>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"ast@...nel.org" <ast@...nel.org>, "hawk@...nel.org" <hawk@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "shradhagupta@...ux.microsoft.com"
	<shradhagupta@...ux.microsoft.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, Konstantin Taranov <kotaranov@...rosoft.com>,
	"horms@...nel.org" <horms@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH net-next] net: mana: Add support for Multi
 Vports on Bare metal



> -----Original Message-----
> From: ALOK TIWARI <alok.a.tiwari@...cle.com>
> Sent: Friday, May 16, 2025 4:57 PM
> To: Haiyang Zhang <haiyangz@...rosoft.com>; linux-hyperv@...r.kernel.org;
> netdev@...r.kernel.org
> Cc: Dexuan Cui <decui@...rosoft.com>; stephen@...workplumber.org; KY
> Srinivasan <kys@...rosoft.com>; Paul Rosswurm <paulros@...rosoft.com>;
> olaf@...fle.de; vkuznets@...hat.com; davem@...emloft.net;
> wei.liu@...nel.org; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; leon@...nel.org; Long Li <longli@...rosoft.com>;
> ssengar@...ux.microsoft.com; linux-rdma@...r.kernel.org;
> daniel@...earbox.net; john.fastabend@...il.com; bpf@...r.kernel.org;
> ast@...nel.org; hawk@...nel.org; tglx@...utronix.de;
> shradhagupta@...ux.microsoft.com; andrew+netdev@...n.ch; Konstantin
> Taranov <kotaranov@...rosoft.com>; horms@...nel.org; linux-
> kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net-next] net: mana: Add support for Multi
> Vports on Bare metal
> 
> 
> 
> On 17-05-2025 01:21, Haiyang Zhang wrote:
> > To support Multi Vports on Bare metal, increase the device config
> response
> > version. And, skip the register HW vport, and register filter steps,
> when
> > the Bare metal hostmode is set.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> >   drivers/net/ethernet/microsoft/mana/mana_en.c | 22 +++++++++++++------
> >   include/net/mana/mana.h                       |  4 +++-
> >   2 files changed, 18 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c
> b/drivers/net/ethernet/microsoft/mana/mana_en.c
> > index 2bac6be8f6a0..0273696d254b 100644
> > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> > @@ -921,7 +921,7 @@ static void mana_pf_deregister_filter(struct
> mana_port_context *apc)
> >
> [snip]
> > +	u8 bm_hostmode = 0;
> >   	u16 num_ports = 0;
> >   	int err;
> >   	int i;
> > @@ -3026,10 +3032,12 @@ int mana_probe(struct gdma_dev *gd, bool
> resuming)
> >   	}
> >
> >   	err = mana_query_device_cfg(ac, MANA_MAJOR_VERSION,
> MANA_MINOR_VERSION,
> > -				    MANA_MICRO_VERSION, &num_ports);
> > +				    MANA_MICRO_VERSION, &num_ports, &bm_hostmode);
> >   	if (err)
> >   		goto out;
> >
> > +	ac->bm_hostmode = bm_hostmode;
> > +
> >   	if (!resuming) {
> >   		ac->num_ports = num_ports;
> >   	} else {
> > diff --git a/include/net/mana/mana.h b/include/net/mana/mana.h
> > index 0f78065de8fe..b352d2a7118e 100644
> > --- a/include/net/mana/mana.h
> > +++ b/include/net/mana/mana.h
> > @@ -408,6 +408,7 @@ struct mana_context {
> >   	struct gdma_dev *gdma_dev;
> >
> >   	u16 num_ports;
> > +	u8 bm_hostmode; /* Bare Metal Host Mode Enabled */
> 
> what about maintaining natural alignment, +u8 reserved0 ?

This is not structure going across the "wire". Compiler will
add holes when necessary. So we don't normally add "reserved"
for alignment in these structs, right?

> /* +response v3: Bare Metal Host Mode Enabled */ for consistency.
> Even though this comment is optional here.

I will just remove this optional comment.

Thanks,
- Haiyang