netdev - Re: [PATCH v28 01/20] net: Introduce direct data placement tcp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516153145.602fc02d@kernel.org>
Date: Fri, 16 May 2025 15:31:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Aurelien Aptel <aaptel@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net, Boris Pismenny
 <borisp@...dia.com>, aurelien.aptel@...il.com, smalin@...dia.com,
 malin1024@...il.com, ogerlitz@...dia.com, yorayz@...dia.com,
 galshalom@...dia.com, mgurtovoy@...dia.com, tariqt@...dia.com,
 gus@...labora.com, pabeni@...hat.com, dsahern@...nel.org, ast@...nel.org,
 jacob.e.keller@...el.com
Subject: Re: [PATCH v28 01/20] net: Introduce direct data placement tcp
 offload

On Fri, 16 May 2025 17:47:34 +0300 Aurelien Aptel wrote:
> The offload works by calling the iter copy functions while skipping the
> memcpy (see patch 3).  We think the unreadable bit is getting close to
> what we want if it wasn't for the skb_datagram_iter() check. Maybe the
> bit could be unset at a later stage but it's not clear where.

Getting rid of the hack in iov_iter may be for the best, actually.
It's pretty ugly.