netdev - Re: [PATCH net-next] net: devmem: remove min_t(iter_iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250517033951.GY2023217@ZenIV>
Date: Sat, 17 May 2025 04:39:51 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	willemb@...gle.com, sagi@...mberg.me, asml.silence@...il.com,
	almasrymina@...gle.com, kaiyuanz@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: devmem: remove min_t(iter_iov_len) in
 sendmsg

On Fri, May 16, 2025 at 07:17:23PM -0700, Stanislav Fomichev wrote:
> > Wait, in the same commit there's
> > +       if (iov_iter_type(from) != ITER_IOVEC)
> > +               return -EFAULT;
> > 
> > shortly prior to the loop iter_iov_{addr,len}() are used.  What am I missing now?
> 
> Yeah, I want to remove that part as well:
> 
> https://lore.kernel.org/netdev/20250516225441.527020-1-stfomichev@gmail.com/T/#u
> 
> Otherwise, sendmsg() with a single IOV is not accepted, which makes not
> sense.

Wait a minute.  What's there to prevent a call with two ranges far from each other?