netdev - Re: [PATCH net-next 02/11] netlink: specs: tc: use tc-gact instead of tc-gen as struct name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m25xhykpn9.fsf@gmail.com>
Date: Sun, 18 May 2025 14:35:38 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org,
  jacob.e.keller@...el.com,  sdf@...ichev.me,  jstancek@...hat.com
Subject: Re: [PATCH net-next 02/11] netlink: specs: tc: use tc-gact instead
 of tc-gen as struct name

Jakub Kicinski <kuba@...nel.org> writes:

> There is a define in the uAPI header called tc_gen which expands
> to the "generic" TC action fields. This helps other actions include
> the base fields without having to deal with nested structs.
>
> A couple of actions (sample, gact) do not define extra fields,
> so the spec used a common tc-gen struct for both of them.
> Unfortunately this struct does not exist in C. Let's use gact's
> (generic act's) struct for basic actions.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>