netdev - Re: [net-next PATCH v4 06/11] net: phy: Export some functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539831fb-398c-4a0a-9540-be6920d301a6@linux.dev>
Date: Mon, 19 May 2025 14:17:43 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, upstream@...oha.com,
 Kory Maincent <kory.maincent@...tlin.com>, Simon Horman <horms@...nel.org>,
 Christian Marangi <ansuelsmth@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v4 06/11] net: phy: Export some functions

On 5/15/25 01:38, Heiner Kallweit wrote:
> On 15.05.2025 04:57, Jakub Kicinski wrote:
>> On Mon, 12 May 2025 12:10:08 -0400 Sean Anderson wrote:
>>> Export a few functions so they can be used outside the phy subsystem:
>>>
>>> get_phy_c22_id is useful when probing MDIO devices which present a
>>> phy-like interface despite not using the Linux ethernet phy subsystem.
>>>
>>> mdio_device_bus_match is useful when creating MDIO devices manually
>>> (e.g. on non-devicetree platforms).
>>>
>>> At the moment the only (future) user of these functions selects PHYLIB,
>>> so we do not need fallbacks for when CONFIG_PHYLIB=n.
>> 
> The functions should only be exported once there is a user.
> Therefore I'd suggest to remove this patch from the series.

These functions are used in patches 5 (oops) and 7. I will split it up
and add it to those patches.

--Sean