netdev - Re: [PATCH iwl-net v3] ice/ptp: fix crosstimestamp reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd79126c-e823-4f1f-a747-a3688f79dc0c@intel.com>
Date: Mon, 19 May 2025 10:50:03 +0200
From: "Nadezhdin, Anton" <anton.nadezhdin@...el.com>
To: Simon Horman <horms@...nel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<anthony.l.nguyen@...el.com>, <richardcochran@...il.com>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, Arkadiusz Kubalewski
	<arkadiusz.kubalewski@...el.com>
Subject: Re: [PATCH iwl-net v3] ice/ptp: fix crosstimestamp reporting

On 5/16/2025 8:58 PM, Simon Horman wrote:
> On Thu, May 15, 2025 at 02:32:36PM +0200, Anton Nadezhdin wrote:
>> Set use_nsecs=true as timestamp is reported in ns. Lack of this result
>> in smaller timestamp error window which cause error during phc2sys
>> execution on E825 NICs:
>> phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument
>>
>> Before commit "Provide infrastructure for converting to/from a base clock"
> 
> Hi Anton,
> 
> Thanks for your patch.
> 
> I have some feedback on the form of the commit message, I hope it is useful.

Hi Simon,

Thank you for the feedback. I will go with such description in the next
version:
ice/ptp: fix crosstimestamp reporting

Set use_nsecs=true as timestamp is reported in ns. Lack of this result
in smaller timestamp error window which cause error during phc2sys
execution on E825 NICs:
phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument

This problem was introduced in the cited commit which omitted setting
use_nsecs to true when converting the ice driver to use
convert_base_to_cs().

Testing hints (ethX is PF netdev):
phc2sys -s ethX -c CLOCK_REALTIME  -O 37 -m
phc2sys[1769.256]: CLOCK_REALTIME phc offset -5 s0 freq      -0 delay   0

> 
> ...