netdev - Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLkyC-MfGUTvcV=zr+LYKzMsyv1im1Oft6EAXYb2x0jGw@mail.gmail.com>
Date: Tue, 20 May 2025 03:32:40 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: chia-yu.chang@...ia-bell-labs.com, linux-doc@...r.kernel.org, 
	corbet@....net, horms@...nel.org, dsahern@...nel.org, kuniyu@...zon.com, 
	bpf@...r.kernel.org, netdev@...r.kernel.org, dave.taht@...il.com, 
	jhs@...atatu.com, kuba@...nel.org, stephen@...workplumber.org, 
	xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net, 
	andrew+netdev@...n.ch, donald.hunter@...il.com, ast@...erby.net, 
	liuhangbin@...il.com, shuah@...nel.org, linux-kselftest@...r.kernel.org, 
	ij@...nel.org, ncardwell@...gle.com, koen.de_schepper@...ia-bell-labs.com, 
	g.white@...lelabs.com, ingemar.s.johansson@...csson.com, 
	mirja.kuehlewind@...csson.com, cheshire@...le.com, rs.ietf@....at, 
	Jason_Livingood@...cast.com, vidhi_goel@...le.com
Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option

On Tue, May 20, 2025 at 2:31 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 5/14/25 3:56 PM, chia-yu.chang@...ia-bell-labs.com wrote:
> > This patch uses the existing 1-byte holes in the tcp_sock_write_txrx
> > group for new u8 members, but adds a 4-byte hole in tcp_sock_write_rx
> > group after the new u32 delivered_ecn_bytes[3] member. Therefore, the
> > group size of tcp_sock_write_rx is increased from 96 to 112.
>
> Note that I'm still concerned by the relevant increase of the cacheline
> groups size. My fear is that this change could defeat some/most of the
> benefist from the cacheline reorg for all tcp users.
>
> Some additional feedback from Eric and/or Neal more than welcome!

I have been trapped lately with production issues, sorry for the delay.

I am still working on an idpf bug, hopefully done today.

Then, I am OOO tomorrow, and can have a look at the whole series on Thursday.

Thanks.