netdev - Re: [PATCH net-next] net: phy: move mdiobus_setup_mdiodev_from_board_info to mdio_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <914ef57a-7c22-448c-b9a3-0580e5311102@redhat.com>
Date: Tue, 20 May 2025 12:45:31 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: move
 mdiobus_setup_mdiodev_from_board_info to mdio_bus_provider.c

On 5/15/25 10:11 PM, Heiner Kallweit wrote:
> Move mdiobus_setup_mdiodev_from_board_info() to mdio_bus_provider.c.
> Benefits are:
> - The function doesn't have to be exported any longer and can be made
>   static.
> - We can call mdiobus_create_device() directly instead of passing it
>   as a callback.
> 
> Only drawback is that now list and mutex have to be exported.

... so the total exports count actually increases, and I personally
think that exporting a function is preferable to exporting a variable.

@Andrew, Russell: WDYT?

Thanks,

Paolo