netdev - Re: [PATCH] ptp: remove ptp->n_vclocks check logic in ptp_vclock_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCyAcbNqKRlPnadx@hoboy.vegasvil.org>
Date: Tue, 20 May 2025 06:15:29 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Jeongjun Park <aha310510@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, yangbo.lu@....com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptp: remove ptp->n_vclocks check logic in
 ptp_vclock_in_use()

On Tue, May 20, 2025 at 12:37:35AM +0900, Jeongjun Park wrote:

> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index 35a5994bf64f..0ae9f074fc52 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -412,9 +412,8 @@ static int unregister_vclock(struct device *dev, void *data)
>  
>  int ptp_clock_unregister(struct ptp_clock *ptp)
>  {
> -	if (ptp_vclock_in_use(ptp)) {
> +	if (ptp_vclock_in_use(ptp))
>  		device_for_each_child(&ptp->dev, NULL, unregister_vclock);
> -	}
>  
>  	ptp->defunct = 1;
>  	wake_up_interruptible(&ptp->tsev_wq);

This hunk is not related to the subject of the patch.  Please remove it.

Thanks,
Richard