netdev - Re: [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250520143736.GT365796@horms.kernel.org>
Date: Tue, 20 May 2025 15:37:36 +0100
From: Simon Horman <horms@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: Jijie Shao <shaojijie@...wei.com>,
	"salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	" lanhao@...wei.com" <lanhao@...wei.com>,
	" wangpeiyang1@...wei.com" <wangpeiyang1@...wei.com>,
	" rosenp@...il.com" <rosenp@...il.com>,
	" liuyonglong@...wei.com" <liuyonglong@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: hns3: Add error handling for VLAN filter
 hardwareconfiguration

On Tue, May 20, 2025 at 09:14:28AM +0800, Wentao Liang wrote:
> > Are there any real functional problems?
> > Would you please tell me your test cases? I'm going to try to reproduce the problem.
> 
> Hi,
> 
> I found this problem by static analysis and manual auditing. I believe there should be add a check just like the other call of hclge_set_vlan_filter_hw(). If the check is useless, could you please tell me the detailed reason.

Thanks,

I think it would be useful for the patch description to state
that the problem was found using static analysis.

But let's wait for more feedback from Jijie on if this
check is, at least theoretically, required.