netdev - Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCypOHoB4fxHW/Di@devbig793.prn5.facebook.com>
Date: Tue, 20 May 2025 09:09:28 -0700
From: Bobby Eshleman <bobbyeshleman@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Stefano Garzarella <sgarzare@...hat.com>,
	Stefan Hajnoczi <stefanha@...hat.com>,
	Shuah Khan <shuah@...nel.org>, kvm@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
	linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for
 vsock

On Tue, May 20, 2025 at 01:24:43PM +0200, Paolo Abeni wrote:
> On 5/16/25 12:00 AM, Bobby Eshleman wrote:
> > +tap_prefix() {
> > +	sed -e "s/^/${TAP_PREFIX}/"
> > +}
> 
> I think there is no need to the tap prefix to the output you intend to
> 'comment out', the kselftest infra should already add the tap prefix
> mark to each line generated by the test,
> 
> > +
> > +tap_output() {
> > +	if [[ ! -z "$TAP_PREFIX" ]]; then
> 
> AFAICS TAP_PREFIX is a not empty string constant, so this function is
> always a no op. If so it should be dropped.
> 
> Otherwise LGTM, thanks,
> 
> Paolo
> 

That sounds good to me. I originally copied that over from
mm/run_vmtests.sh because their they do have an option for disabling TAP
output (if running as non-kselftest)... but I didn't add the knob to do
that here and am not sure when that might be used so might as well
remove it.

I'll go ahead and remove all of the tap style output.

Best,
Bobby