netdev - Re: [PATCH v17 1/3] lsm, selinux: Add setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb68761b5a2d53702f4d6b80fe2a6457@paul-moore.com>
Date: Tue, 20 May 2025 17:15:59 -0400
From: Paul Moore <paul@...l-moore.com>
To: Li Li <dualli@...omium.org>, dualli@...gle.com, corbet@....net, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, donald.hunter@...il.com, gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com, maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org, cmllamas@...gle.com, surenb@...gle.com, omosnace@...hat.com, shuah@...nel.org, arnd@...db.de, masahiroy@...nel.org, bagasdotme@...il.com, horms@...nel.org, tweek@...gle.com, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, netdev@...r.kernel.org, selinux@...r.kernel.org, linux-security-module@...r.kernel.org, hridya@...gle.com
Cc: smoreland@...gle.com, ynaffit@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH v17 1/3] lsm, selinux: Add setup_report permission to  binder

On Apr 16, 2025 Li Li <dualli@...omium.org> wrote:
> 
> Introduce a new permission "setup_report" to the "binder" class.
> This persmission controls the ability to set up the binder generic
> netlink driver to report certain binder transactions.
> 
> Signed-off-by: Thiébaud Weksteen <tweek@...gle.com>
> Signed-off-by: Li Li <dualli@...gle.com>
> ---
>  include/linux/lsm_hook_defs.h       |  1 +
>  include/linux/security.h            |  6 ++++++
>  security/security.c                 | 13 +++++++++++++
>  security/selinux/hooks.c            |  7 +++++++
>  security/selinux/include/classmap.h |  3 ++-
>  5 files changed, 29 insertions(+), 1 deletion(-)

When possible, it is helpful to include at least one caller in the patch
which adds a new LSM hook as it helps put the hook in context.  With that
in mind, I think it would be best to reorder this patchset so that patch
2/3 comes first and this patch comes second, with this patch including
the change to binder_nl_report_setup_doit() which adds the call to the
new LSM hook.

--
paul-moore.com