netdev - Re: [PATCH v2 1/2] i40e: return false from i40e_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADcc-bzq2BCL07SOjzdMXypE8Y4bLkAuurwZ0YwHuffdpar_OA@mail.gmail.com>
Date: Tue, 20 May 2025 10:33:10 +0200
From: Robert Malz <robert.malz@...onical.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, 
	przemyslaw.kitszel@...el.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	sylwesterx.dziedziuch@...el.com, mateusz.palczewski@...el.com, 
	jacob.e.keller@...el.com
Subject: Re: [PATCH v2 1/2] i40e: return false from i40e_reset_vf if reset is
 in progress

On Mon, May 19, 2025 at 11:22 PM Tony Nguyen <anthony.l.nguyen@...el.com> wrote:
>
>
>
> On 5/16/2025 2:47 AM, Robert Malz wrote:
> > The function i40e_vc_reset_vf attempts, up to 20 times, to handle a
> > VF reset request, using the return value of i40e_reset_vf as an indicator
> > of whether the reset was successfully triggered. Currently, i40e_reset_vf
> > always returns true, which causes new reset requests to be ignored if a
> > different VF reset is already in progress.
> >
> > This patch updates the return value of i40e_reset_vf to reflect when
> > another VF reset is in progress, allowing the caller to properly use
> > the retry mechanism.
> >
> > Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered on another VF")
> > Signed-off-by: Robert Malz <robert.malz@...onical.com>
> > ---
> >   drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> > index 1120f8e4bb67..2f1aa18bcfb8 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> > @@ -1546,8 +1546,8 @@ static void i40e_cleanup_reset_vf(struct i40e_vf *vf)
> >    * @vf: pointer to the VF structure
> >    * @flr: VFLR was issued or not
> >    *
> > - * Returns true if the VF is in reset, resets successfully, or resets
> > - * are disabled and false otherwise.
> > + * Returns true if reset was performed successfully or if resets are
> > + * disabled. False if reset is already in progress.
>
> nit but if we are editing this, let's make kdoc happy. Please start with
> Return: or Returns:
>
> Thanks,
> Tony
>

Hey Tony, thanks for the review. Fixed in v3.
Regards,
Robert