netdev - Re: [PATCH v16 01/22] cxl: Add type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d2eb2d2-f269-4921-99f1-c6deb973cf42@amd.com>
Date: Wed, 21 May 2025 10:30:25 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Dave Jiang <dave.jiang@...el.com>,
 Alison Schofield <alison.schofield@...el.com>, alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v16 01/22] cxl: Add type2 device basic support


On 5/20/25 21:06, Dave Jiang wrote:
>
> On 5/20/25 12:18 AM, Alejandro Lucero Palau wrote:
>> Hi Allison,
>>
>> On 5/20/25 03:43, Alison Schofield wrote:
>>> On Wed, May 14, 2025 at 02:27:22PM +0100, alejandro.lucero-palau@....com wrote:
>>>> From: Alejandro Lucero <alucerop@....com>
>>>>
>>>> Differentiate CXL memory expanders (type 3) from CXL device accelerators
>>>> (type 2) with a new function for initializing cxl_dev_state and a macro
>>>> for helping accel drivers to embed cxl_dev_state inside a private
>>>> struct.
>>>>
>>>> Move structs to include/cxl as the size of the accel driver private
>>>> struct embedding cxl_dev_state needs to know the size of this struct.
>>>>
>>>> Use same new initialization with the type3 pci driver.
>>>>
>>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>>>
>>> snip
>>
>> Thank you for all the review tags. Much appreciated.
>>
>>
>> I'm afraid Dave merged the patchset some hours ago. Maybe he can still add your tags at some point since I think he is using a specific branch for this merge which will likely be merged to another one in the next days.
>>
>>
>> Dave, can you reply here for knowing you have read it?
> Hi Alejandro, sorry about the confusion. The branch I had you test was a test branch for my local testing before merging. The code has not been officially merged as it was not pushed to cxl/next branch upstream. It looks like there are some concerns we need to address from Alison and Dan.


Hi Dave. No worries.


I'll address Dan's concerns and send then a v17. AFAIK, there are no 
concerns from Allison, only review tags.


Thanks

>>