netdev - Re: [PATCH v9 net-next 5/8] net: ena: Add debugfs support to the ENA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0754879f-5dbe-4748-8af3-0a588c90bcc0@lunn.ch>
Date: Wed, 21 May 2025 14:38:56 +0200
From: Andrew Lunn <andrew@...n.ch>
To: David Arinzon <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	"Woodhouse, David" <dwmw@...zon.com>,
	"Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>,
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>,
	"Liguori, Anthony" <aliguori@...zon.com>,
	"Bshara, Nafea" <nafea@...zon.com>,
	"Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>,
	"Kiyanovski, Arthur" <akiyano@...zon.com>,
	"Dagan, Noam" <ndagan@...zon.com>,
	"Bernstein, Amit" <amitbern@...zon.com>,
	"Agroskin, Shay" <shayagr@...zon.com>,
	"Ostrovsky, Evgeny" <evostrov@...zon.com>,
	"Tabachnik, Ofir" <ofirt@...zon.com>,
	"Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Gal Pressman <gal@...dia.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH v9 net-next 5/8] net: ena: Add debugfs support to the ENA
 driver

> +void ena_debugfs_init(struct net_device *dev)
> +{
> +	struct ena_adapter *adapter = netdev_priv(dev);
> +
> +	adapter->debugfs_base =
> +		debugfs_create_dir(dev_name(&adapter->pdev->dev), NULL);
> +	if (IS_ERR(adapter->debugfs_base))
> +		netdev_err(dev, "Failed to create debugfs dir\n");

Don't check return codes from debugfs_ calls. It does not matter if it
fails, it is just debug, and all debugfs_ calls are happy to take a
NULL pointer, ERR_PTR() etc.

	Andrew