netdev - Re: [PATCH v3] selftests: can: Import tst-filter from can-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5487982-2a7a-44ca-95d6-f270a7533749@wanadoo.fr>
Date: Wed, 21 May 2025 23:07:16 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Felix Maurer <fmaurer@...hat.com>, socketcan@...tkopp.net,
 mkl@...gutronix.de
Cc: shuah@...nel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 linux-can@...r.kernel.org, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, dcaratti@...hat.com, fstornio@...hat.com
Subject: Re: [PATCH v3] selftests: can: Import tst-filter from can-tests

On 21/05/2025 at 22:16, Felix Maurer wrote:
> Tests for the can subsystem have been in the can-tests repository[1] so
> far. Start moving the tests to kernel selftests by importing the current
> tst-filter test. The test is now named test_raw_filter and is substantially
> updated to be more aligned with the kernel selftests, follow the coding
> style, and simplify the validation of received CAN frames. We also include
> documentation of the test design. The test verifies that the single filters
> on raw CAN sockets work as expected.
> 
> We intend to import more tests from can-tests and add additional test cases
> in the future. The goal of moving the CAN selftests into the tree is to
> align the tests more closely with the kernel, improve testing of CAN in
> general, and to simplify running the tests automatically in the various
> kernel CI systems.
> 
> [1]: https://github.com/linux-can/can-tests
> 
> Signed-off-by: Felix Maurer <fmaurer@...hat.com>

Thanks. I will send a follow-up patch which will add the support of physical can
interfaces.

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>


Yours sincerely,
Vincent Mailhol