netdev - Re: [PATCH v4] net: rds: Replace strncpy with strscpy in connection setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4230bbdccb082ad9dee651ccb51c8426ac0b753.camel@oracle.com>
Date: Wed, 21 May 2025 17:21:07 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "shankari.ak0208@...il.com" <shankari.ak0208@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "horms@...nel.org" <horms@...nel.org>,
        "shuah@...nel.org"
	<shuah@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH v4] net: rds: Replace strncpy with strscpy in connection
 setup

On Wed, 2025-05-21 at 18:28 +0530, Shankari Anand wrote:
> Replaces strncpy() with strscpy_pad() for copying the transport field.
> Unlike strscpy(), strscpy_pad() ensures the destination buffer is fully padded with null bytes, avoiding garbage data.
> This is safer for struct copies and comparisons. As strncpy() is deprecated (see: kernel.org/doc/html/latest/process/deprecated.html#strcpy),
> this change improves correctness and adheres to kernel guidelines for safe, bounded string handling.
> 
> Signed-off-by: Shankari Anand <shankari.ak0208@...il.com>
Hi Shankari,

Thanks for the patch, but it looks like Baris already submitted a similar patch, and I believe the two argument variant
is correct for this use case since cinfo->transport is a fixed sized array.

Thank you for your patch submission though!
Allison

> ---
>  net/rds/connection.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/rds/connection.c b/net/rds/connection.c
> index c749c5525b40..4689062db84f 100644
> --- a/net/rds/connection.c
> +++ b/net/rds/connection.c
> @@ -749,7 +749,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
>  	cinfo->laddr = conn->c_laddr.s6_addr32[3];
>  	cinfo->faddr = conn->c_faddr.s6_addr32[3];
>  	cinfo->tos = conn->c_tos;
> -	strncpy(cinfo->transport, conn->c_trans->t_name,
> +	strscpy_pad(cinfo->transport, conn->c_trans->t_name,
>  		sizeof(cinfo->transport));
>  	cinfo->flags = 0;
>  
> @@ -775,7 +775,7 @@ static int rds6_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
>  	cinfo6->next_rx_seq = cp->cp_next_rx_seq;
>  	cinfo6->laddr = conn->c_laddr;
>  	cinfo6->faddr = conn->c_faddr;
> -	strncpy(cinfo6->transport, conn->c_trans->t_name,
> +	strscpy_pad(cinfo6->transport, conn->c_trans->t_name,
>  		sizeof(cinfo6->transport));
>  	cinfo6->flags = 0;
>