netdev - Re: [PATCH net-next v5 3/5] vsock/test: Introduce vsock_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc18e277-ef88-49e2-9e51-982752253325@rbox.co>
Date: Thu, 22 May 2025 01:06:24 +0200
From: Michal Luczaj <mhal@...x.co>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>,
 virtualization@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH net-next v5 3/5] vsock/test: Introduce vsock_wait_sent()
 helper

On 5/21/25 17:01, Stefano Garzarella wrote:
> On Wed, May 21, 2025 at 12:55:21AM +0200, Michal Luczaj wrote:
>> ...
>> +/* Wait until transport reports no data left to be sent.
>> + * Return non-zero if transport does not implement the unsent_bytes() callback.
>> + */
>> +int vsock_wait_sent(int fd)
> 
> nit: I just see we use `bool` in the test to store the result of this 
> function, so maybe we can return `bool` directl from here...
> 
> (not a strong opinion, it's fine also this).

Yeah, why not, let's do bool.

Thanks,
Michal