netdev - RE: [Intel-wired-lan] [iwl-next v3 1/8] ice, libie: move generic adminq descriptors to lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62419AD24802CA4CF0A2FA548B9EA@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Wed, 21 May 2025 06:44:53 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v3 1/8] ice, libie: move generic
 adminq descriptors to lib

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal Swiatkowski
> Sent: 25 April 2025 11:38
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Lobakin, Aleksander <aleksander.lobakin@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Kwapulinski, Piotr <piotr.kwapulinski@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Zaremba, Larysa <larysa.zaremba@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v3 1/8] ice, libie: move generic adminq descriptors to lib
>
> The descriptor structure is the same in ice, ixgbe and i40e. Move it to
common libie header to use it across different driver.
>
> Leave device specific adminq commands in separate folders. This lead to
a change that need to be done in filling/getting descriptor:
> - previous: struct specific_desc *cmd;
	    cmd = &desc.params.specific_desc;
> - now: struct specific_desc *cmd;
       cmd = libie_aq_raw(&desc);
>
> Do this changes across the driver to allow clean build. The casting only
have to be done in case of specific descriptors, for generic one union
can still be used.
>
> Changes beside code moving:
> - change ICE_ prefix to LIBIE_ prefix (ice_ and libie_ too)
> - remove shift variables not otherwise needed (in libie_aq_flags)
> - fill/get descriptor data based on desc.params.raw whenever the
  descriptor isn't defined in libie
> - move defines from the libie_aq_sth structure outside
> - add libie_aq_raw helper and use it instead of explicit casting
>
> Reviewed by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h          |   2 +-
> .../net/ethernet/intel/ice/ice_adminq_cmd.h   | 270 +-----------
> drivers/net/ethernet/intel/ice/ice_common.h   |   6 +-
> drivers/net/ethernet/intel/ice/ice_controlq.h |   8 +-
> include/linux/net/intel/libie/adminq.h        | 272 ++++++++++++
> .../net/ethernet/intel/ice/devlink/health.c   |   4 +-
> drivers/net/ethernet/intel/ice/ice_common.c   | 390 +++++++++---------
> drivers/net/ethernet/intel/ice/ice_controlq.c |  53 +--
> drivers/net/ethernet/intel/ice/ice_dcb.c      |  36 +-
> drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   2 +-
> drivers/net/ethernet/intel/ice/ice_ddp.c      |  47 +--
> .../net/ethernet/intel/ice/ice_fw_update.c    |  24 +-
> drivers/net/ethernet/intel/ice/ice_fwlog.c    |  16 +-
> drivers/net/ethernet/intel/ice/ice_lag.c      |   4 +-
> drivers/net/ethernet/intel/ice/ice_lib.c      |   6 +-
> drivers/net/ethernet/intel/ice/ice_main.c     |  34 +-
> drivers/net/ethernet/intel/ice/ice_nvm.c      |  38 +-
> drivers/net/ethernet/intel/ice/ice_ptp_hw.c   |  20 +-
> drivers/net/ethernet/intel/ice/ice_sched.c    |  18 +-
> drivers/net/ethernet/intel/ice/ice_sriov.c    |   4 +-
> drivers/net/ethernet/intel/ice/ice_switch.c   |  55 +--
> drivers/net/ethernet/intel/ice/ice_vf_mbx.c   |   6 +-
> drivers/net/ethernet/intel/ice/ice_virtchnl.c |   2 +-
> .../net/ethernet/intel/ice/ice_vlan_mode.c    |   6 +-
> 24 files changed, 673 insertions(+), 650 deletions(-)
> create mode 100644 include/linux/net/intel/libie/adminq.h
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)