netdev - Re: [PATCH net-next] xsk: add missing virtual address conversion for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250522124348.GZ365796@horms.kernel.org>
Date: Thu, 22 May 2025 13:43:48 +0100
From: Simon Horman <horms@...nel.org>
To: Bui Quang Minh <minhquangbui99@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] xsk: add missing virtual address conversion for
 page

On Wed, May 21, 2025 at 03:56:33PM +0700, Bui Quang Minh wrote:
> In commit 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use
> page_pool_dev_alloc()"), when converting from netmem to page, I missed a
> call to page_address() around skb_frag_page(frag) to get the virtual
> address of the page. This commit uses skb_frag_address() helper to fix
> the issue.
> 
> Signed-off-by: Bui Quang Minh <minhquangbui99@...il.com>

I agree that this is a fix for net-next. But as such I think it needs:

Fixes: 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use page_pool_dev_alloc()")

Assuming that is correct then I don't think you need to repost just for
this. The tag should be picked up by automation by virtue of being present
in this email.

Reviewed-by: Simon Horman <horms@...nel.org>