netdev - Re: [PATCH net-next] net: phy: Synchronize c45_ids to phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <831a5923-5946-457e-8ff6-e92c8a0818fd@lunn.ch>
Date: Thu, 22 May 2025 15:39:04 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Synchronize c45_ids to phy_id

On Thu, May 22, 2025 at 09:19:18PM +0800, Yajun Deng wrote:
> The phy_id_show() function emit the phy_id for the phy device. If the phy
> device is a c45 device, the phy_id is empty. In other words, phy_id_show()
> only works with the c22 device.
> 
> Synchronize c45_ids to phy_id, phy_id_show() will work with both the c22
> and c45 devices.

First off, they are different things. A device can have both a C22 and
a collection of C45 IDs. So they should not be mixed up in one sysfs
attribute.

The second point has already been made by Russell, there are lots of
different C45 IDs, and phylib will try to find a driver based on any
of them.

If you want to export the C45 IDs, please think about adding new sysfs
attributes.

	Andrew