netdev - Re: [PATCH v2 00/10] net: faster and simpler CRC32C computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250522070705.19fa9ca6@kernel.org>
Date: Thu, 22 May 2025 07:07:05 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: netdev@...r.kernel.org, linux-nvme@...ts.infradead.org,
 linux-sctp@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Sagi Grimberg
 <sagi@...mberg.me>, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2 00/10] net: faster and simpler CRC32C computation

On Mon, 19 May 2025 10:50:02 -0700 Eric Biggers wrote:
> Update networking code that computes the CRC32C of packets to just call
> crc32c() without unnecessary abstraction layers.  The result is faster
> and simpler code.
> 
> Patches 1-7 add skb_crc32c() and remove the overly-abstracted and
> inefficient __skb_checksum().
> 
> Patches 8-10 replace skb_copy_and_hash_datagram_iter() with
> skb_copy_and_crc32c_datagram_iter(), eliminating the unnecessary use of
> the crypto layer.  This unblocks the conversion of nvme-tcp to call
> crc32c() directly instead of using the crypto layer, which patch 9 does.
> 
> Please consider this series for net-next for 6.16.

Applied to net-next with Leon's ack he sent to v1.
Thanks!