netdev - Re: [PATCH net-next] eth: bnxt: fix deadlock when xdp is attached or detached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174792903799.2925590.1720080745754415485.git-patchwork-notify@kernel.org>
Date: Thu, 22 May 2025 15:50:37 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, andrew+netdev@...n.ch, horms@...nel.org, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 michael.chan@...adcom.com, pavan.chebbi@...adcom.com, sdf@...ichev.me,
 netdev@...r.kernel.org, bpf@...r.kernel.org, jdamato@...tly.com,
 martin.lau@...nel.org, hramamurthy@...gle.com
Subject: Re: [PATCH net-next] eth: bnxt: fix deadlock when xdp is attached or
 detached

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 20 May 2025 07:11:55 +0000 you wrote:
> When xdp is attached or detached, dev->ndo_bpf() is called by
> do_setlink(), and it acquires netdev_lock() if needed.
> Unlike other drivers, the bnxt driver is protected by netdev_lock while
> xdp is attached/detached because it sets dev->request_ops_lock to true.
> 
> So, the bnxt_xdp(), that is callback of ->ndo_bpf should not acquire
> netdev_lock().
> But the xdp_features_{set | clear}_redirect_target() was changed to
> acquire netdev_lock() internally.
> It causes a deadlock.
> To fix this problem, bnxt driver should use
> xdp_features_{set | clear}_redirect_target_locked() instead.
> 
> [...]

Here is the summary with links:
  - [net-next] eth: bnxt: fix deadlock when xdp is attached or detached
    https://git.kernel.org/netdev/net-next/c/db807e5ef8ee

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html