netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to 'hashcfg' for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB586540A78EB452FAEEC207308F99A@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Thu, 22 May 2025 18:16:27 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, Intel Wired LAN
	<intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, netdev <netdev@...r.kernel.org>
CC: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Simon Horman <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename
 'hena' to 'hashcfg' for clarity

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jacob
> Keller
> Sent: Monday, May 5, 2025 10:14 PM
> To: Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev <netdev@...r.kernel.org>
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>; Simon Horman <horms@...nel.org>
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' to
> 'hashcfg' for clarity
> 
> i40e, ice, and iAVF all use 'hena' as a shorthand for the "hash enable"
> configuration. This comes originally from the X710 datasheet 'xxQF_HENA'
> registers. In the context of the registers the meaning is fairly clear.
> 
> However, on its own, hena is a weird name that can be more difficult to
> understand. This is especially true in ice. The E810 hardware doesn't even have
> registers with HENA in the name.
> 
> Replace the shorthand 'hena' with 'hashcfg'. This makes it clear the variables deal
> with the Hash configuration, not just a single boolean on/off for all hashing.
> 
> Do not update the register names. These come directly from the datasheet for
> X710 and X722, and it is more important that the names can be searched.
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>