netdev - Re: [net Patchv2] octeontx2-pf: QOS: Refactor TC_HTB_LEAF_DEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250522200314.GN365796@horms.kernel.org>
Date: Thu, 22 May 2025 21:03:14 +0100
From: Simon Horman <horms@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sunil Goutham <sgoutham@...vell.com>,
	Geetha sowjanya <gakula@...vell.com>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Naveen Mamindlapalli <naveenm@...vell.com>
Subject: Re: [net Patchv2] octeontx2-pf: QOS: Refactor TC_HTB_LEAF_DEL_LAST
 callback

On Thu, May 22, 2025 at 05:28:42PM +0530, Hariprasad Kelam wrote:
> This patch addresses below issues,
> 
> 1. Active traffic on the leaf node must be stopped before its send queue
>    is reassigned to the parent. This patch resolves the issue by marking
>    the node as 'Inner'.
> 
> 2. During a system reboot, the interface receives TC_HTB_LEAF_DEL
>    and TC_HTB_LEAF_DEL_LAST callbacks to delete its HTB queues.
>    In the case of TC_HTB_LEAF_DEL_LAST, although the same send queue
>    is reassigned to the parent, the current logic still attempts to update
>    the real number of queues, leadning to below warnings
> 
>         New queues can't be registered after device unregistration.
>         WARNING: CPU: 0 PID: 6475 at net/core/net-sysfs.c:1714
>         netdev_queue_update_kobjects+0x1e4/0x200
> 
> Fixes: 5e6808b4c68d ("octeontx2-pf: Add support for HTB offload")
> Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> ---
> v2* update the commit description about making qid as inner.

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>