netdev - Re: [PATCH net-next 06/26] netfilter: nf_tables: nft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250523132610.GV365796@horms.kernel.org>
Date: Fri, 23 May 2025 14:26:10 +0100
From: Simon Horman <horms@...nel.org>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netfilter-devel@...r.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, fw@...len.de
Subject: Re: [PATCH net-next 06/26] netfilter: nf_tables: nft_fib: consistent
 l3mdev handling

On Fri, May 23, 2025 at 09:39:29AM +0200, Pablo Neira Ayuso wrote:
> On Fri, May 23, 2025 at 08:35:24AM +0100, Simon Horman wrote:
> > On Thu, May 22, 2025 at 06:52:18PM +0200, Pablo Neira Ayuso wrote:
> > > @@ -39,6 +40,21 @@ static inline bool nft_fib_can_skip(const struct nft_pktinfo *pkt)
> > >  	return nft_fib_is_loopback(pkt->skb, indev);
> > >  }
> > >  
> > > +/**
> > > + * nft_fib_l3mdev_get_rcu - return ifindex of l3 master device
> > 
> > Hi Pablo,
> > 
> > I don't mean to hold up progress of this pull request. But it would be nice
> > if at some point the above could be changed to
> > nft_fib_l3mdev_master_ifindex_rcu so it matches the name of the function
> > below that it documents.
> > 
> > Flagged by ./scripts/kernel-doc -none
> 
> Thanks for letting me know, I can resubmit the series, let me know.

I'd lean towards fixing it later unless there is another reason to
resubmit the series.