netdev - Re: [PATCH net-next V2 11/11] net/mlx5e: Support ethtool tcp-data-split settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f1e6469dc0f3f9dda4741bb3213e0dc86f3805a.camel@nvidia.com>
Date: Fri, 23 May 2025 16:17:46 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "kuba@...nel.org" <kuba@...nel.org>, "saeed@...nel.org" <saeed@...nel.org>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "hawk@...nel.org"
	<hawk@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "leon@...nel.org"
	<leon@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "ast@...nel.org"
	<ast@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Dragos Tatulea
	<dtatulea@...dia.com>, Mark Bloch <mbloch@...dia.com>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed
	<saeedm@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal
 Pressman <gal@...dia.com>, "daniel@...earbox.net" <daniel@...earbox.net>,
	Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net-next V2 11/11] net/mlx5e: Support ethtool
 tcp-data-split settings

On Thu, 2025-05-22 at 16:19 -0700, Saeed Mahameed wrote:
> > 
> > The kernel_param->tcp_data_split here is the user config, right?
> > It would be cleaner to not support setting SPLIT_DISABLED.
> > Nothing requires that, you can support just setting AUTO and
> > ENABLED.
> > 
> 
> I think I agree, AUTO might require some extra work on the driver
> side to
> figure out current internal mode, but it actually makes more sense
> than
> just doing "UNKNOWN", UKNOWN here means that HW GRO needs to be
> enabled
> when disabling TCP HDR split, and we still don't know if that will
> work..
> 
> Cosmin will you look into this ? 

Yes, I will address all comments from this round by the next
submission.

Cosmin.