netdev - Re: [PATCH v1 net 2/2] net: lan743x: Fix PHY reset handling during initialization and WOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6b4862-df38-4b9e-9add-beaeebbbefc0@lunn.ch>
Date: Fri, 23 May 2025 18:25:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Thangaraj Samynathan <thangaraj.s@...rochip.com>
Cc: bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 net 2/2] net: lan743x: Fix PHY reset handling during
 initialization and WOL

On Fri, May 23, 2025 at 11:13:25AM +0530, Thangaraj Samynathan wrote:
> Remove lan743x_phy_init from lan743x_hardware_init as it resets the PHY
> registers, causing WOL to fail on subsequent attempts. Add a call to
> lan743x_hw_reset_phy in the probe function to ensure the PHY is reset
> during device initialization.
> 
> Fixes: 23f0703c125be ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@...rochip.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew