netdev - Re: [PATCH ipsec 2/2] xfrm: state: use a consistent pcpu_id in xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDC6lpnfvhWoeM-C@strlen.de>
Date: Fri, 23 May 2025 20:12:38 +0200
From: Florian Westphal <fw@...len.de>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Steffen Klassert <steffen.klassert@...unet.com>,
	Antony Antony <antony.antony@...unet.com>,
	Tobias Brunner <tobias@...ongswan.org>
Subject: Re: [PATCH ipsec 2/2] xfrm: state: use a consistent pcpu_id in
 xfrm_state_find

Sabrina Dubroca <sd@...asysnail.net> wrote:
> If we get preempted during xfrm_state_find, we could run
> xfrm_state_look_at using a different pcpu_id than the one
> xfrm_state_find saw.

[..]

> This can be avoided by passing the original pcpu_id down to all
> xfrm_state_look_at() calls.

FWIW I found this get/put pair slightly confusing as well, so:

Reviewed-by: Florian Westphal <fw@...len.de>