netdev - Re: [PATCH v8 4/9] coredump: add coredump socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e9ccdad-a9f4-4c8f-85b0-430edd910590@infradead.org>
Date: Thu, 22 May 2025 17:59:39 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org,
 Jann Horn <jannh@...gle.com>, Daniel Borkmann <daniel@...earbox.net>,
 Kuniyuki Iwashima <kuniyu@...zon.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>, linux-mips@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>, Oleg Nesterov <oleg@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Daan De Meyer <daan.j.demeyer@...il.com>,
 David Rheinsberg <david@...dahead.eu>, Jakub Kicinski <kuba@...nel.org>,
 Jan Kara <jack@...e.cz>, Lennart Poettering <lennart@...ttering.net>,
 Luca Boccassi <luca.boccassi@...il.com>, Mike Yuan <me@...dnzj.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-security-module@...r.kernel.org,
 Alexander Mikhalitsyn <alexander@...alicyn.com>
Subject: Re: [PATCH v8 4/9] coredump: add coredump socket

Hi,

On 5/16/25 4:25 AM, Christian Brauner wrote:
> Coredumping currently supports two modes:
> 

> ---
>  fs/coredump.c       | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>  include/linux/net.h |   1 +
>  net/unix/af_unix.c  |  54 ++++++++++++++++++------
>  3 files changed, 156 insertions(+), 17 deletions(-)
> 

[snip]

git a/include/linux/net.h b/include/linux/net.h> index 0ff950eecc6b..139c85d0f2ea 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -81,6 +81,7 @@ enum sock_type {
>  #ifndef SOCK_NONBLOCK
>  #define SOCK_NONBLOCK	O_NONBLOCK
>  #endif
> +#define SOCK_COREDUMP	O_NOCTTY
>  
>  #endif /* ARCH_HAS_SOCKET_TYPES */

MIPS sets ARCH_HAS_SOCKET_TYPES so the new define above is not used,
causing:

net/unix/af_unix.c:1152:21: error: 'SOCK_COREDUMP' undeclared (f
irst use in this function); did you mean 'SOCK_RDM'?

-- 
~Randy